getall: cleaner, support Recursive #98
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @aplavin what happened with this PR? Is there something blocking it? |
|
For reducing code generation (
For adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, I try out a different
getallimplementation based on the trick from FluxML/Functors.jl#61.It:
@generatedfunction remains, but maybe it can be removed?),Recursive, even easier thanComposedFunction!Can potentially close the
getallpart of get/set all values referred by an optic #63,Leavesoptic #14, get/set queries #23.The
getalllimit forComposedFunctioninference seems to become lower than before, though. It affects one test that tested the maximal depth of 10.Well, the
getall(ComposedFunction)implementation may stay as before with@eval, only addingRecursivefrom this PR...@jw3126 @rafaqz @cscherrer